-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC module wiring with uber-go dig #9529
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Module wiring using uber's dig dependency injection container.
There are two approaches to module wiring demonstrated here:
Provide*
method approach, see https://github.com/cosmos/cosmos-sdk/blob/aaronc/minimal-di-wiring-v3/x/auth/module/module.go. In this approach, allProvide*
methods are used in the dependency injection container automatically withModuleKey
being a special parameter.Provisioner
interface approach, see: https://github.com/cosmos/cosmos-sdk/blob/aaronc/minimal-di-wiring-v3/x/gov/module/module.go. In this approach,Provision
is called with aModuleKey
and acontainer.Option
is returned.container.Option
is inspired by uber-go/fx: https://pkg.go.dev/go.uber.org/fx#Option, and it's a nicer way to compose things than usingdig.Provide
directly.I think I pretty strongly prefer the first
Provide*
method approach for most module development because it just looks cleaner to my eyes. (Also it could be amenable to static analysis a la google/wire in the future but I'm not even sure it's worth it at this point.) I do think the fxOption
approach is good for lower-level "non-module" providers.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change